Enemy Territory

Project: Bug Fix

The objective

The goal of this project is to provide modders in the ET community with a SDK code base that contains fixes for various bugs which are present in the stock etmain game (version 2.60).

26th september 2006: Sadly bugfix 088 had a bug :-( There were 3 lines that should have been deleted for the fix to work correctly.

Show index
Previous bug: g_inactivity is missing from the pub cvar table, and causing a pointer crash
Next bug: During intermission the 'players' command was checking the wrong flag to see who is ready

Bugfix 060 - Muted players becoming referee can't get unmuted

Problem:

There is no logic in not allowing referees to be unmuted.

Solution:

So comment out the referee restriction from unmute in g_vote and check the mute state in g_referee.

References:

Spawning thread

Notes:

The bug is still present in version 2.60

2.56 & 2.60 Code

g_vote.c @ 445 (2.56) @ 444 (2.60) else if((pid = ClientNumberFromString(ent, arg2)) == -1) return(G_INVALID);
if(level.clients[pid].sess.referee) { // CHRUKER: b060 - Referees can always be unmuted G_refPrintf(ent, "Can't vote to un-mute referees!"); return(G_INVALID); }
if(!level.clients[pid].sess.muted) {
g_referee.c @ 366 (2.56) @ 377 (2.60) player = g_entities + pid;
// CHRUKER: b060 - Added mute check so that players that are muted before granted referee status, can be unmuted
if( player->client->sess.referee != RL_NONE && mute ) { G_refPrintf(ent, "Cannot mute a referee." ); // CHRUKER: b047 - Removed unneeded linebreak return; }

Show index
Previous bug: g_inactivity is missing from the pub cvar table, and causing a pointer crash
Next bug: During intermission the 'players' command was checking the wrong flag to see who is ready

Color coding

Sample = New code
Sample = Changed code (the new version is what is displayed)
Sample = Deleted code

©2017 Chruker