Enemy Territory
Error in Bugfix 55 (Error messages in the scripting system were printing the wrong index ranges)
Forum index » Enemy Territory - Project - Bug Fix

Author Message
Elite
Posted 04-11-2007, 16:49:12
Hey, I was just passing though this Bugfix again (don't know why I do it so often :) ), and I happened to notice an error in Bugfix 55 (Error messages in the scripting system were printing the wrong index ranges).


=======================
In ai_script_actions.c
========================
-> First code block appears correct in bugfix.
-> Second code block needs to use the G_MAX_SCRIPT_ACCUM_BUFFERS instead of just the MAX_SCRIPT_ACCUM_BUFFERS
-> Third code block is supposed to use MAX_SCRIPT_ACCUM_BUFFERS and not G_MAX_SCRIPT_ACCUM_BUFFERS as the fix indicates
-> Fouth code block should be the one that uses G_MAX_SCRIPT_ACCUM_BUFFERS instead of MAX_SCRIPT_ACCUM_BUFFERS


=======================
In g_script_actions.c
========================
-> Missing a fix at line 582 (perhaps line 580, my line's are off a tad from the bugfix). It's using G_MAX_SCRIPT_ACCUM_BUFFERS where it needs to use MAX_SCRIPT_ACCUM_BUFFERS
-> First code block (line 596 in Bugfix) was allready fine, it does need to use G_MAX_SCRIPT_ACCUM_BUFFERS and not MAX_SCRIPT_ACCUM_BUFFERS as outlined in the bugfix
-> Second code block needs to use G_MAX_SCRIPT_ACCUM_BUFFERS... the index range was the only thing changed there
-> Third code block again is incorrent... it says to use MAX_SCRIPT_ACCUM_BUFFERS in the bugfix, but really you need to use G_MAX_SCRIPT_ACCUM_BUFFERS
-> Fouth code block needs to use MAX_SCRIPT_ACCUM_BUFFERS, not G_MAX_SCRIPT_ACCUM_BUFFERS as outlined in bugfix
-> Fifth code block again needs to use G_MAX_SCRIPT_ACCUM_BUFFERS, not MAX_SCRIPT_ACCUM_BUFFERS as outlined in the bugfix


To sum it up, I think the order of the code is just a bit shuffled, but it may mislead some people who aren't paying attention to which accum is being used

Reply You need to login before you can post a reply to the thread.
The time is now 25-06-2017, 20:54:45

New thread
Login | Register | Memberlist

©2017 Chruker